Implement a new resampling algorithm in AudioStreamPlaybackResampled #46086
Conversation
In the long term, it would be interesting to add a project setting to configure the audio resampler. We could also have a Nearest option which gives a "punchier" result with low-sample rate sounds. Some people may prefer this kind of sound rendering when working on a game with retro sounds. That should be discussed in a proposal anyway 🙂 |
|
Should I add a proposal for this? Since it's associated with a long-standing bug I thought I'd go ahead and make the PR, but I can go and write up a proposal for it if people want to discuss. |
|
@ellenhp I opened a proposal: godotengine/godot-proposals#2298 I think this PR could be merged as-is for |
akien-mga
added
the
cherrypick:3.x
|
@ellenhp Looks great. To be honest I think for this use case going to something better than cubic will most likely not produce any audible results to players, but given this is not really costly, we don't lose anything by implementing it. @Calinou for these types of streams, I honestly don't think you want to change the interpolation. For regular sample streams maybe for artistic/retro reasons in sound effects but to be honest you can simulate the aliasing or bitcrushing in a separate application and import the sound already decimated. |
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
|
@reduz I think it's an edge case but I did notice a difference in very low-pitched sounds without any high frequency components. The resampling artifacts sound like ringing almost, and it's only apparent when there's no treble for it to hide behind. The first comment in the bug this closed has a good example of it. Which reminds me. Should I do the same for wav streams? |
|
I would prefer if we used the same resampling algorithm for all audio formats. This way, your sounds won't change in "feeling" if you go from one audio format to another. |
|
Sounds good. I'll do that after work today. |
|
I'd love if this ends up in 3.2.4. I'm making a rhythm game where audio is very important, but there's very hearable ringing, especially in low end of the spectrum. :( |
|
Well see: #46086 (comment) You can already use it in 3.2.4 RC 3. |
|
It's in the latest release candidate along with a bunch of other audio fixes I made recently, and unless this is reverted it'll make it into the final release cut too. It should be fixed in RC3 as long as you're using oggs or mp3s. WAV resampling hasn't been switched over to this new algorithm yet (see: #46245), but in my testing I found the ringing there to be far less noticeable. Oggs and mp3s had some really bad ringing. If you test 3.2.4 RC 3 and find this hasn't been solved, comment on #23544 and @ tag me so I get an email about it. It would be useful to know if you have this issue with wav files so I can push on #46245. With my bad ears, I can't tell the difference between before and after for wavs though, so unless someone reports issues I'm fine without #46245. |
|
Oops, i didn't think it was in RC3 because it didn't get listed there among fixes. My bad. However i just downloaded RC3 and tested with OGG, and don't notice any reduction to ringing. :( I'll provide a video that showcases the issue in #23544 then and try with MP3 and WAV as well. |
Fixes #23544
This implements a new resampling algorithm for MP3s and oggs. The algorithm is described in this paper as "4 point, 4th order optimal" and seems to perform much better than the cubic algorithm used previously. This algorithm seems free to use from the header of the paper. "Distribute, host and use this paper freely." The intent is very clear, and I know Godot uses algorithms from other papers (for example, the SPCAP algorithm) so I'm hoping this will be fine.
This algorithm looks slower just from the increased number of multiplies, but I doubt that it's an issue. I can profile it if people want me to though, and if it is an issue it might make sense to add a project option to let people choose.
To test, download the example project in #23544 and use the ogg file in the project (the wav file playback uses a separate codepath). You may need to increase your volume before the resampling artifacts become obvious. It may also be worth trying different speakers/headphones if you're having trouble reproducing the bug.