Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTL] Do not break line on the span (e.g. RTL BBCode tag) edges. #45440

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 25, 2021

Do not break line on the span (e.g. RTL BBCode tag) edges (except "language" tags which implies line breaking rules change).

Fixes #41963, fixes #31089

Screen.Recording.2021-01-25.at.09.39.31.mov

@bruvzg bruvzg added this to the 4.0 milestone Jan 25, 2021
@akien-mga akien-mga merged commit 161c4be into godotengine:master Jan 25, 2021
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the ctl_span_breaks branch February 15, 2021 10:30
@ibe-denaux
Copy link

Is this fix planned to be implemented into v3.x?

@LemonadeFlashbang
Copy link

Just commenting support for a 3.x compatible fix- I use color to highlight items/skills/etc., and this issue will punt the following punctuation down to a new line which is a fairly large polish hit.

@Calinou
Copy link
Member

Calinou commented Mar 14, 2022

Just commenting support for a 3.x compatible fix- I use color to highlight items/skills/etc., and this issue will punt the following punctuation down to a new line which is a fairly large polish hit.

3.x does not use the Complex Text Layouts system (which is backwards-incompatible), so this fix needs to be reimplemented from scratch in 3.x.

@LemonadeFlashbang
Copy link

I figured as much. For my use case it's a priority fix so worst case I'll learn how to make the change myself or I'll hire a more knowledgeable dev, but I wanted to flag this issue as still impactful in the shorter term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants