Remove Quat set methods in favour of constructors #45407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godot/core/variant/variant_call.cpp
Lines 1129 to 1131 in d39f638
A
Quat
should be immutable. It should not haveset_*
methods. When required, a newQuat
should be created using the equivalent constructor.This PR removes the
Quat
set_*
methods, and, where used, replaces them with the constructor equivalents. Note: This PR does not makeQuat
immutable. It's components are still public and they can still be (and are) changed within the engine.For reference, deprecating them was originally suggested by @aaronfranke here as part of #16863.