Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Mono: Fix support for Unicode identifiers #45279

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

magian1127
Copy link
Contributor

@magian1127 magian1127 commented Jan 18, 2021

[Export] private string dq当前动作 = "idle";

Garbled code will be displayed in the editor

add
String::utf8()

Normal display in editor

4.0

@magian1127 magian1127 requested a review from neikeq as a code owner January 18, 2021 08:47
@akien-mga akien-mga modified the milestones: 4.0, 3.2 Jan 18, 2021
@akien-mga akien-mga changed the title mono supports Unicode code Mono: Fix support for Unicode identifiers Jan 18, 2021
@akien-mga akien-mga changed the title Mono: Fix support for Unicode identifiers [3.2] Mono: Fix support for Unicode identifiers Jan 18, 2021
@neikeq
Copy link
Contributor

neikeq commented Jan 19, 2021

Why is this 3.2 only?

@magian1127
Copy link
Contributor Author

Why is this 3.2 only?

I only used 3.2,
So I haven't seen 4.0 code,
I'll go to PR later.

@akien-mga akien-mga merged commit 2fa93d8 into godotengine:3.2 Jan 19, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants