Fix file name comparison when new file is added to file system

[fmazan]

Fixes #45027.

It was caused by improper comparison between full file path vs. file name only.

[KiritoAM]

Looks good to me!
Note that the associated bug is only present if your file list is sorted by name (FILE_SORT_NAME or FILE_SORT_NAME_REVERSE). This is because FileSystemDock::_sort_file_info_list (which is called when the filesystem changes) does not call the relevant sort_custom variant on the file list for these two sorting types; we assume that the list is already sorted by FILE_SORT_NAME when it enters the function; which it wasn't in this case (with this fix, it now is). Not sure if the same issue is occurring elsewhere due to this assumption.
This does mean that the better fix may be to call sort_custom under these two sorting methods; but personally I'm happy with this fix for this particular issue.

[fmazan]

Looks good to me!
Note that the associated bug is only present if your file list is sorted by name (FILE_SORT_NAME or FILE_SORT_NAME_REVERSE). This is because FileSystemDock::_sort_file_info_list (which is called when the filesystem changes) does not call the relevant sort_custom variant on the file list for these two sorting types; we assume that the list is already sorted by FILE_SORT_NAME when it enters the function; which it wasn't in this case (with this fix, it now is). Not sure if the same issue is occurring elsewhere due to this assumption.
This does mean that the better fix may be to call sort_custom under these two sorting methods; but personally I'm happy with this fix for this particular issue.

Indeed, my first local fix was to force sorting in case of FILE_SORT_NAME and FILE_SORT_NAME_REVERSE, but that was curing symptom rather than the cause. I have looked around the code, and it seemed to me that the files vector was purposely kept sorted by name at all times.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.2.4.