Fix Variant conversion to float instead of double #44306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
real_t
is defined as afloat
(or adouble
depending on a flag it seems?) incore/math/math_defs.h
andVariant::construct
was thus casting to a float.Instead of using a double, maybe it is better to fix whatever is causing the flag not to be set?
godot/core/math/math_defs.h
Lines 109 to 113 in 2a4f0bc
Closes #44303