Fix bug in normal map decompression #44293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not clamping the range here leads to dithering artifacts.
Fixes #43309
This seemed obviously wrong in the canvas shader which was leading to artifacts, see the full discussion in #44285. Although the latter issue shows a problem in the sprite 3d, my very quick look suggested the scene shaders were not suffering from the same flaw.
There may be another fix that can be applied for the scene shaders. I'm just doing this as a separate PR as I have to rush off.
Notes
Example before / after