Set Environment's Ao Channel Effect to 1.0 by default #43960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Ao Channel Affect" was defaulting to 0, giving unexpected results. This meant that as soon as you set an AO texture on a material, there will no longer be SSAO on that material. This led many users to think that Godot didn't support using SSAO and AO textures at the same time. This closes godotengine#43957.
|
Should this pr also handle the importer changes? |
fire
changed the title
|
Superseded by #45023.
This pull request could perhaps be remade for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Ao Channel Affect" was defaulting to 0, giving unexpected results. This meant that as soon as you set an AO texture on a material, there will no longer be SSAO on that material.
This led many users to think that Godot didn't support using SSAO and AO textures at the same time.
This closes #43957.