Make sure to inizialize the r_error.error on Variant::construct #43535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to initialize the
r_error.error
whenVariant::construct
is called.The error passed to the function
Variant::construct
is not initialized: https://github.com/godotengine/godot/blob/master/modules/gdscript/gdscript_function.cpp#L958-L959Since not all the constructors defined here: https://github.com/godotengine/godot/blob/master/core/variant/variant_construct.cpp#L738 always set
r_error.error
to something, happens that the errorBug, call error: #426275124
is raised with a random number, even when the function succeed.Correct functions:
Bad functions:
If we initialize the variable to
CALL_OK
, as I did in this PR, we can just leave the task to the above functions to set the error only when there is an error. In this way we can also make that mechanism less error prone and so more robust. Though, not sure if you would like to also setCALL_OK
into those functions, or just leave them as are @reduz.