-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Fix multiple issues with one-way collisions #42575
[3.2] Fix multiple issues with one-way collisions #42575
Conversation
d7f0bf6
to
e63187f
Compare
e63187f
to
bfa5036
Compare
I'm approving this for the same reasons explained here: #42574 (comment). (In this case, considering 3.2 is the production release, the part about testing a project which uses one-way heavily is much more important.) |
bfa5036
to
a7d06a7
Compare
a7d06a7
to
780fc6b
Compare
Updated with the changes applied to #42574 i.e. both KinematicBody and RigidBody treat perpendicular contacts as pass through; and removed the change that was causing the bug. |
780fc6b
to
a327229
Compare
53b7e04
to
98604f1
Compare
Updated to properly fix the bugs identified by @Rhathe. |
98604f1
to
eb2d3fb
Compare
Updated to include the fix for #43266, identified by @AttackButton here. |
eb2d3fb
to
83f326c
Compare
Updated to ensure the work around applied in the previous update only applies during the unsticking phase. |
f66f43e
to
736e036
Compare
Updated to include the small refactor that removed some unneeded code. |
For RigidBodies, uses the collision normal determined by relative motion to determine whether or not a one-way collision has occurred. For KinematicBodies, performs additional checks to ensure a one-way collision has occurred, and averages the recovery step over all collision shapes. Co-authored-by: Sergej Gureev <[email protected]>
736e036
to
1061bb3
Compare
Updated to include the changes applied to #42574:
|
Thanks! |
3.2 version of #42574, i.e a salvage of #40645.