Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind get_total_visible_rows function to gdscript #42522

Closed
wants to merge 1 commit into from

Conversation

vmjcv
Copy link

@vmjcv vmjcv commented Oct 3, 2020

i need bind get_total_visible_rows function to gdscript
this is my problem(https://godotforums.org/discussion/comment/42260#Comment_42260)
when i bind the function in gdscript,everything is ok
I feel get_total_visible_rows is a required method, like get_line_count

@aaronfranke aaronfranke added this to the 4.0 milestone Oct 3, 2020
@akien-mga akien-mga requested a review from a team February 22, 2021 20:25
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label and RichTextLabel expose similar function, so it makes sense to include it here too. But any newly exposed method needs a documentation written in the PR (you can use doctool to generate blank entry and fill the description).

Also, up to discussion, but the equivalent method in Label/RichTextLabel is called get_visible_line_count(). Maybe here it should have this name too, for consistency? We don't need to rename the method, the binding could have a different name.

@akien-mga
Copy link
Member

akien-mga commented May 17, 2021

Superseded by #48528. Thanks for the contribution nevertheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants