Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the documentation related to fullscreen and borderless settings #41746

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Improve the documentation related to fullscreen and borderless settings #41746

merged 1 commit into from
Nov 6, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 3, 2020

Based on a discussion with people on Discord.

@Calinou Calinou requested a review from a team as a code owner September 3, 2020 20:01
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation enhancement labels Sep 3, 2020
@Calinou Calinou force-pushed the doc-projectsettings-fullscreen-borderless branch from 191f9a1 to fc33a3f Compare September 3, 2020 20:02
@bruvzg
Copy link
Member

bruvzg commented Sep 3, 2020

FYI, in case someone really needs true resolution change, I have experimental "exclusive full screen" module: https://github.com/bruvzg/gd_fs_control, it's not updated for a while but should work with current 3.2.

Clone to modules/fs_control, rebuild the engine and use FSController.change_mode_exclusive_fullscreen(Vector3(w, h, refresh_rate), screen_index) to change resolution.

@akien-mga akien-mga added this to the 4.0 milestone Sep 24, 2020
@Calinou Calinou mentioned this pull request Oct 28, 2020
Closed
@Calinou
Copy link
Member Author

Calinou commented Oct 28, 2020

I amended the pull request per @bruvzg's comment and also documented the fullscreen behavior in the DisplayServer and Window classes.

@Calinou Calinou force-pushed the doc-projectsettings-fullscreen-borderless branch from fc33a3f to b1ae285 Compare October 28, 2020 13:27
@Calinou Calinou force-pushed the doc-projectsettings-fullscreen-borderless branch from b1ae285 to a1f81a5 Compare October 28, 2020 13:30
@akien-mga akien-mga merged commit a9bc440 into godotengine:master Nov 6, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Nov 10, 2020
Closed
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 11, 2020
@Calinou Calinou mentioned this pull request Jan 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @bruvzg @akien-mga