Create a .lgtm.yml file to enable lgtm to successfully build Godot. #41739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've added the LGTM badge in #35958, it's worth making sure that it at least builds successfully. Currently, the C/C++ build is failing, because it's using Ubuntu 19.10, which has an old version of SCons that has the old shebang and therefore tries to run it with Python 2.7.
This PR creates a basic LGTM yaml file (
.lgtm.yml) that installs the current version of SCons, which has the#! /usr/bin/python3shebang, and then updates the path appropriately. This enables a C/C++ build using SCons to succeed; as tested here.Note: The test says the C/C++ analysis failed. However, the stated reason for the failure is that it timed out during the analysis phase, not that the build failed during the extraction phase. Furthermore, the log shows that the analysis completed (8 minutes after it timed out); so this may be a bug on their end. The important point is that it now builds succesfully.