Edit vector/rect properties in a "linked" manner when holding down Ctrl #41555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Rect2, Rect2i and AABB, this only applies to the size, not the position. This closes godotengine/godot-proposals#144.
Calinou
added
cherrypick:3.x
nathanfranke
suggested changes
Aug 27, 2020
| v3.z = spin[2]->get_value(); | ||
| if (Input::get_singleton()->is_key_pressed(KEY_CONTROL)) { | ||
| // Set all components to the edited value to quickly set "linked" values such as scale. | ||
| if (p_name == "x") { |
There was a problem hiding this comment.
_value_changed has a val parameter. Use that instead of whatever this is.
|
I think that a link button would make more sense. I did a bit of work in my fork |
nathanfranke
suggested changes
Aug 27, 2020
There was a problem hiding this comment.
Added the lines to change and suggestions (Thanks @aaronfranke)
Comment on lines
+1338
to
+1352
| if (p_name == "x") { | ||
| v3.x = spin[0]->get_value(); | ||
| v3.y = spin[0]->get_value(); | ||
| v3.z = spin[0]->get_value(); | ||
| } else if (p_name == "y") { | ||
| v3.x = spin[1]->get_value(); | ||
| v3.y = spin[1]->get_value(); | ||
| v3.z = spin[1]->get_value(); | ||
| } else if (p_name == "z") { | ||
| v3.x = spin[2]->get_value(); | ||
| v3.y = spin[2]->get_value(); | ||
| v3.z = spin[2]->get_value(); | ||
| } else { | ||
| ERR_PRINT("Unexpected component name (please report)."); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (p_name == "x") { | |
| v3.x = spin[0]->get_value(); | |
| v3.y = spin[0]->get_value(); | |
| v3.z = spin[0]->get_value(); | |
| } else if (p_name == "y") { | |
| v3.x = spin[1]->get_value(); | |
| v3.y = spin[1]->get_value(); | |
| v3.z = spin[1]->get_value(); | |
| } else if (p_name == "z") { | |
| v3.x = spin[2]->get_value(); | |
| v3.y = spin[2]->get_value(); | |
| v3.z = spin[2]->get_value(); | |
| } else { | |
| ERR_PRINT("Unexpected component name (please report)."); | |
| } | |
| v3 = Vector3(val, val, val); |
Comment on lines
+1651
to
+1665
| if (p_name == "x") { | ||
| v3.x = spin[0]->get_value(); | ||
| v3.y = spin[0]->get_value(); | ||
| v3.z = spin[0]->get_value(); | ||
| } else if (p_name == "y") { | ||
| v3.x = spin[1]->get_value(); | ||
| v3.y = spin[1]->get_value(); | ||
| v3.z = spin[1]->get_value(); | ||
| } else if (p_name == "z") { | ||
| v3.x = spin[2]->get_value(); | ||
| v3.y = spin[2]->get_value(); | ||
| v3.z = spin[2]->get_value(); | ||
| } else { | ||
| ERR_PRINT("Unexpected component name (please report)."); | ||
| } |
There was a problem hiding this comment.
Same with above
Suggested change
| if (p_name == "x") { | |
| v3.x = spin[0]->get_value(); | |
| v3.y = spin[0]->get_value(); | |
| v3.z = spin[0]->get_value(); | |
| } else if (p_name == "y") { | |
| v3.x = spin[1]->get_value(); | |
| v3.y = spin[1]->get_value(); | |
| v3.z = spin[1]->get_value(); | |
| } else if (p_name == "z") { | |
| v3.x = spin[2]->get_value(); | |
| v3.y = spin[2]->get_value(); | |
| v3.z = spin[2]->get_value(); | |
| } else { | |
| ERR_PRINT("Unexpected component name (please report)."); | |
| } | |
| v3 = Vector3(val, val, val); |
|
@Calinou What's the status of this PR? Do you plan to continue working on this? There are requested changes above that need to be addressed. |
|
Superseded by #59125. |
akien-mga
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet. This PR needs to be modified so it doesn't link coordinates when dragging properties to change their values while holding down Ctrl.
For Rect2, Rect2i and AABB, this only applies to the size, not the position.
This closes godotengine/godot-proposals#144.
Note: When cherry-picking to the
3.2branch, remove the parts that modify the integer vector types as these aren't present in 3.2.x.