Properly handle empty CSGCombiners #40919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2020
madmiraal
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
My only concern with this change is that there is a slight break in compact in that the Operation of the first CSGShape in the CSGCombiner is now relevant. If it is set to anything but Union (i.e Subtraction or Intersection) it won't be copied, and it will result in nothing. However, this is easily fixed by setting it to Union which is the default.
madmiraal
added
bug
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Cannot get CSGBrush" error spam.
Fixes #24696.
Fixes #40782.