Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Add tests option to enable or disable unit tests #40696

Merged
merged 1 commit into from
Jul 25, 2020
Merged

SCons: Add tests option to enable or disable unit tests #40696

merged 1 commit into from
Jul 25, 2020

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Jul 25, 2020

Closes godotengine/godot-proposals#107.
Helps to workaround #40666.
Remake of #32387.

SConstruct Outdated Show resolved Hide resolved
@RevoluPowered
Copy link
Contributor

Can we edit the main/tests/scsub so that if tests=no nothing is done in that directory compilation wise?

@Xrayez
Copy link
Contributor Author

Xrayez commented Jul 25, 2020

Yeah this is already the case, but the check is within main/SCsub which calls into tests/SCsub, building with tests=no would prevent going into that dir.

if env["tests"]:
    SConscript("tests/SCsub")

That said, it's not possible to return from SCsub directly.

@Xrayez Xrayez marked this pull request as draft July 25, 2020 15:40
@Xrayez
Copy link
Contributor Author

Xrayez commented Jul 25, 2020

Added tests=yes to CI configs which run tests, because tests are disabled by default now, as suggested.

@Xrayez Xrayez marked this pull request as ready for review July 25, 2020 16:04
@akien-mga akien-mga merged commit 325af10 into godotengine:master Jul 25, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TESTS_ENABLED option and ability to opt-out from compiling tests
3 participants