[WIP] FIX: MSVC compiler missing header breaking debugging #40681
Conversation
|
Can you try to get this upstreamed too? Or a better version of it without the capslocks :P |
|
Don't merge only fixes win32... so not the entire fix. |
RevoluPowered
changed the title
|
Is it related to doctest/doctest#381 ? |
he missed platform fix see new commit |
|
|
||
| DOCTEST_THREAD_LOCAL std::ostringstream g_oss; // NOLINT(cert-err58-cpp) | ||
|
|
||
| #if defined(DOCTEST_PLATFORM_WINDOWS) |
There was a problem hiding this comment.
Let's try to keep the indentation correct even if it's a hotfix :)
And see @bruvzg's comment about editing third-party libs.
There was a problem hiding this comment.
will do sorry MSVC keeps lagging out when I type in it... I will update with a real text editor and squash at the end once we are certain this is gone :D
|
It seems like it's possible to get into editor in 50% of times with current changes (compared to 30%), but I still get crashes on startup while debugging. D: |
OK I updated all to use thread_local statically with the windows platform only. Please let me know if the crash is gone |
|
No, it may have improved the situation, but I might have just got lucky enough to run it 10 times in a row, but then crashes again 5 times in a row. 😄 |
RevoluPowered
force-pushed
the
fix-crash-msvc-doctest
branch
from
0c41535 to
138326c
Compare
|
Closing: this fix 'kind of worked' but its mostly a hack, we can fix with swapping to /MD but ideally don't want to do this. |
Fixes #40666
Caused by a problem in the MSVC compiler, and thread_local on windows.