Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2] Move Bullet physics query flush from Bullet space pre-tick callback to Bullet physics flush_queries() #40185

Merged
merged 1 commit into from
Jul 10, 2020
Merged

[3.2] Move Bullet physics query flush from Bullet space pre-tick callback to Bullet physics flush_queries() #40185

merged 1 commit into from
Jul 10, 2020

Conversation

madmiraal
Copy link
Contributor

3.2 version of #40184.

@madmiraal madmiraal requested a review from AndreaCatania as a code owner July 7, 2020 19:07
@aaronfranke aaronfranke added this to the 3.2 milestone Jul 7, 2020
@madmiraal
Move Bullet physics query flush from Bullet space pre-tick callback to
e7d8464 
Bullet physics flush_queries() as is done in Godot physics, and remove
the pre-tick callback.
@madmiraal
Copy link
Contributor Author

Updated to also remove the pre-tick callback; as suggested here.

@akien-mga akien-mga merged commit 2cf5207 into godotengine:3.2 Jul 10, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-37702-3.2 branch July 10, 2020 11:04
@Cykyrios Cykyrios mentioned this pull request Jul 18, 2020
Open
@akien-mga
Copy link
Member

Reverted with 10544f1 to fix #40508 for 3.2. This can be re-applied after 3.2.3 has been released, together with a backport of #40252 and #40188.

@madmiraal If you want to make a new PR for 3.2 that reapplies this commit so that we don't forget about it, that would be great :)

@madmiraal madmiraal mentioned this pull request Jul 28, 2020
Open
3 tasks
@hoontee hoontee mentioned this pull request Aug 2, 2020
Closed
@madmiraal madmiraal mentioned this pull request Aug 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaCatania AndreaCatania Awaiting requested review from AndreaCatania

Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@madmiraal @akien-mga @aaronfranke