Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mismatched disable half float property string #39426

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Fixed mismatched disable half float property string #39426

merged 1 commit into from
Jun 10, 2020

Conversation

Rubonnek
Copy link
Member

Fixes #39425

@Rubonnek Rubonnek requested a review from reduz as a code owner June 10, 2020 03:05
@akien-mga akien-mga added this to the 3.2 milestone Jun 10, 2020
@akien-mga akien-mga requested review from clayjohn and lawnjelly and removed request for reduz June 10, 2020 08:31
@akien-mga
Copy link
Member

That seems wrong to me?

$ rg disable_half_float
doc/classes/ProjectSettings.xml
1006:           <member name="rendering/gles2/debug/disable_half_float" type="bool" setter="" getter="" default="false">

drivers/gles2/rasterizer_storage_gles2.cpp
5976:   bool disable_half_float = GLOBAL_GET("rendering/gles2/debug/disable_half_float");
5977:   if (disable_half_float) {

servers/visual_server.cpp
2433:   GLOBAL_DEF("rendering/gles2/debug/disable_half_float", false);

@akien-mga
Copy link
Member

Nevermind, I was checking on a slightly older commit. This changed in #39068.

@akien-mga akien-mga merged commit 4f02fd7 into godotengine:3.2 Jun 10, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Jun 10, 2020
Closed
@lawnjelly
Copy link
Member

Thanks! 👍 Sorry it's been a bit mad with the project settings changes! 😁

@Rubonnek Rubonnek deleted the unmatched-half-float branch June 10, 2020 15:43
@Rubonnek
Copy link
Member Author

@lawnjelly No worries! I'm glad to help with anything I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn Awaiting requested review from clayjohn

@lawnjelly lawnjelly Awaiting requested review from lawnjelly

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Rubonnek @akien-mga @lawnjelly