Test collision mask before creating constraint pair in Godot physics broadphase 2D and 3D. #39399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…broadphase 2D and 3D.
YeldhamDev
added
bug
cherrypick:3.x
|
Curious if it might also close this? #28460 Tried testing, but I had some merge conflicts in 3.2 that I wasn't able to resolve. Do these extra pairs impact performance noticeably? |
|
@avencherus The 3.2 version is here. |
|
@avencherus It does indeed fix #28460 too. Thanks for spotting it. |
akien-mga
removed
the
cherrypick:3.x
|
Thanks! |
|
@madmiraal Nice work, thanks. All looks good in the monitor with various combinations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28460.
Fixes #39374.
Note: This fix is only needed in Godot physics (2D and 3D). Bullet physics'
RigidBodysalready works as expected.Edit: Also fixes #16541.