Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the bottom panel visible when enabling the distraction-free mode #39177

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 30, 2020

  • Document EditorInterface.set_distraction_free_mode() and rename its enter parameter to enable for clarity.

This closes godotengine/godot-proposals#951.

@Calinou Calinou requested a review from a team as a code owner May 30, 2020 21:00
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation enhancement topic:editor usability labels May 30, 2020
@Calinou Calinou added this to the 4.0 milestone May 30, 2020
@Calinou Calinou force-pushed the distraction-free-keep-bottom-panel-visible branch 2 times, most recently from 861f571 to 9362cf4 Compare May 30, 2020 21:46
@akien-mga
Copy link
Member

It's a bit hard to know if this is a wanted change given the low amount of interaction on the proposal.
I'm not against it but as it stands it's a bit arbitrary. Maybe a Twitter poll with screenshots would help decide?

@Calinou
Copy link
Member Author

Calinou commented Jun 3, 2020

@akien-mga Feel free to make such a poll 🙂 Make sure to state the upsides of keeping the bottom panel visible too (easier access to the panels).

@akien-mga
Copy link
Member

Well I meant more for you to make a Twitter, since you're already used to doing so for other UX changes you've done ;)

@YuriSizov
Copy link
Contributor

If it's any references, inability to work with the Debugger, Output and Search Results panels while in DFM was one of my points in this Reddit post and godotengine/godot-proposals#512. While people were arguing about some things, I don't remember them arguing that this was not a problem.

Indeed, it doesn't make any sense to use the Script editor without those tools, and as such makes the distraction-free mode in its current form rather pointless. Unless someone likes to toggle it constantly to switch back and forth between being able to code and being able to see the bottom panel (which would be irritating, if you ask me).

I seriously doubt, that anyone finds what is currently offered by this utility mode any useful. There may be a better solution, but this is definitely a problem.

@hilfazer
Copy link
Contributor

hilfazer commented Jun 11, 2020

If Distraction Free Mode's purpose is working with code then it absolutely should support global search.

I don't have a Twitter account so i'm casting my vote here.

@akien-mga
Copy link
Member

Nobody seems really against it, so let's merge once rebased.

- Document the `EditorInterface.distraction_free_mode` property.

This closes godotengine/godot-proposals#951.
@Calinou Calinou force-pushed the distraction-free-keep-bottom-panel-visible branch from 9362cf4 to e6352d1 Compare June 26, 2020 20:09
@akien-mga akien-mga merged commit bcf7e51 into godotengine:master Jun 26, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Output and Debugger visible when using script editor in distraction-free mode
4 participants