Fix certain characters being recognized as special keys on Windows when using the us international layout #38820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
cherrypick:3.x
akien-mga
reviewed
May 18, 2020
…en using the us international layout
|
Thanks for reviewing! I've changed the code according to your comments. |
akien-mga
approved these changes
May 18, 2020
|
Thanks! |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As supposed by the participants of #25548, the problem is that certain characters emit special key signals additionally. I found this post on stackoverflow bringing some light into the darkness.
I have implemented a simple check to see if a WM_CHAR message sends a special key signal, and if so, the message is discarded.
Fixes #25548