Fix crash in stb_vorbis.c #38422
Merged
Fix crash in stb_vorbis.c #38422
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
bug
topic:thirdparty
cherrypick:3.x
|
Just tested this branch and the bug is fixed! |
|
Thanks! |
|
Nice. Fixes the crash on startup in my 3.2 build. |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 20, 2020
Upstreams our crash fixes from godotengine#38422 and godotengine#40174.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 24, 2020
Upstreams our crash fixes from godotengine#38422 and godotengine#40174. (cherry picked from commit 8dffca4)
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
Upstreams our crash fixes from godotengine#38422 and godotengine#40174.
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
Upstreams our crash fixes from godotengine#38422 and godotengine#40174. (cherry picked from commit 8dffca4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38418.
UPDATE: Upstream PR at nothings/stb#961.