Improve consistency in file order #37796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
|
Could you squash the commits into one? The temporary showing of the reload button is not relevant to the git history. |
|
Ok, I did it! |
KoBeWi
approved these changes
May 17, 2021
There was a problem hiding this comment.
Seems fine, but needs rebase. Here's a rebased patch, just use git apply:
0001-Improve-consistency-in-file-order.patch.txt
…e consistency. Fixes godotengine#37721.
|
I pushed a rebased commit to |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37721 by ensuring that files in EditorFileSystem and ScriptEditor are sorted using NaturalNoCaseComparator. Since EditorFileSystem will always be correctly sorted, no additional sorting is required in i.e. FileSystemDock