Alias platform=x11 to platform=linuxbsd in SCons
#37369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
scons-x11-alias-linuxbsd
branch
2 times, most recently
from
607a39c to
1402c38
Compare
|
Can we also add a |
|
I agree with @aaronfranke, this should help reduce accidental build frustrations for new users. Unless we reach 5+ aliases I don't think it'll cause any confusion. |
Calinou
force-pushed
the
scons-x11-alias-linuxbsd
branch
from
1402c38 to
56ca1ff
Compare
|
I added aliases for |
akien-mga
reviewed
Mar 28, 2020
Calinou
force-pushed
the
scons-x11-alias-linuxbsd
branch
from
56ca1ff to
5fb7e6e
Compare
akien-mga
reviewed
Mar 28, 2020
This makes it possible for users to follow outdated documentation and still get a working binary. This closes godotengine#37367.
Calinou
force-pushed
the
scons-x11-alias-linuxbsd
branch
from
5fb7e6e to
59fbbdc
Compare
akien-mga
approved these changes
Mar 28, 2020
aaronfranke
approved these changes
Mar 28, 2020
|
Thanks! |
accidentalrebel
added a commit
to accidentalrebel/godot
that referenced
this pull request
Mar 31, 2020
Fixes godotengine#37465. The godotengine#37369 commit which added an alias for linuxbsd platform did not work with the latest branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for users to follow outdated documentation and still get a working binary.
PS: We might want to do the opposite in the
3.2branch (aliaslinuxbsdtox11). This way, people can also follow documentation intended for 4.0 to build Godot 3.2. I expect that to be quite common if we update the Compiling for X11 page in themasterbranch…Edit: This now aliases
linuxandbsdtolinuxbsdfor convenience as well.This closes #37367.