Improve the editor feature profiles UX #37235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an help message when no profile is selected.
- This replaces the class/property trees which are now hidden
when no profile is selected.
- Display `(none)` as the current profile when no profile is
currently active.
- Make the newly created/imported profile the current if it's the
first profile to be added to the list.
- Make more strings localizable.
Calinou
force-pushed
the
improve-editor-feature-profiles
branch
from
cb30482 to
4a1f22d
Compare
|
Thanks! |
akien-mga
added a commit
that referenced
this pull request
May 25, 2020
It used APIs that were changed after the PR was last rebased.
|
why shouldn't godot provide a profile by default instead, wouldn't that make more sense and isn't that the expected behaviour? i bet that most people are going to ignore that message i don't think this fixes the problem at all, the user still needs to deal with the fact that it's not intuitive at all, to me this just very poorly hides the problem away, but it still fails to solve anything really |
|
@RaTcHeT302 The "default" feature profile implicitly enables all editor features. Maybe we should rename |
rileylyman
pushed a commit
to rileylyman/godot
that referenced
this pull request
May 25, 2020
It used APIs that were changed after the PR was last rebased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #49643.(none)as the current profile when no profile is currently active.These changes should hopefully clear up some confusion related to the editor feature profiles UI 🙂
Preview
No profile has been created yet (freshly opened dialog).
This closes #39022.