Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements estimate/compute_cost for AStar2D #37039

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Implements estimate/compute_cost for AStar2D #37039

merged 1 commit into from
Mar 19, 2020

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Mar 14, 2020

Fix #36990

@Chaosus Chaosus added this to the 4.0 milestone Mar 14, 2020
@Chaosus Chaosus added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 14, 2020
@Chaosus Chaosus requested a review from a team as a code owner March 14, 2020 07:33
aaronfranke
aaronfranke previously requested changes Mar 14, 2020
View reviewed changes
core/math/a_star.h Outdated Show resolved Hide resolved
@Chaosus Chaosus requested a review from aaronfranke March 14, 2020 08:02
@aaronfranke aaronfranke removed their request for review March 14, 2020 08:48
@akien-mga akien-mga merged commit 256ac9a into godotengine:master Mar 19, 2020
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the astar2d_cost branch March 19, 2020 07:28
@eltharionx
Copy link

Not sure where else to ask this, but does this fix plan on being released on the next Godot 3.2.x release?

@eltharionx eltharionx mentioned this pull request Apr 10, 2020
Closed
@Calinou
Copy link
Member

Calinou commented Apr 10, 2020 •
edited
Loading

@eltharionx This pull request has the cherrypick:3.2 label, which means it will be cherry-picked for Godot 3.2.3 when Akien gets around to it.

@akien-mga
Copy link
Member

Cherry-picked for 3.2.2.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke left review comments

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

AStar2D cannot override _estimate_cost or _compute_cost in GDScript
5 participants
@Chaosus @akien-mga @eltharionx @Calinou @aaronfranke