Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes crash when saving scene #36407

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Fixes crash when saving scene #36407

merged 1 commit into from
Sep 13, 2020

Conversation

timothyqiu
Copy link
Member

This fixes #36253

@YeldhamDev YeldhamDev added this to the 4.0 milestone Feb 21, 2020
@timothyqiu timothyqiu force-pushed the maybe-copy-paste-error branch from 3a896ea to 38147da Compare September 13, 2020 08:20
@timothyqiu
Copy link
Member Author

Hi. The issue is still producible on the current master.

I rebased this PR onto the master branch and resolved the merge conflict. Hope this can be reviewed soon :)

@akien-mga
Copy link
Member

@reduz says it looks good too.

@akien-mga akien-mga merged commit de465c4 into godotengine:master Sep 13, 2020
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the maybe-copy-paste-error branch September 14, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Editor crash when saving scene
4 participants
@timothyqiu @akien-mga @clayjohn @YeldhamDev