Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputState class and refactor default input implementation #35240

Closed
wants to merge 1 commit into from
Closed

Add InputState class and refactor default input implementation #35240

wants to merge 1 commit into from

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Jan 17, 2020

Resolves godotengine/godot-proposals#104.
Resolves godotengine/godot-proposals#100.

This is a concrete implementation of the new InputState class which aims to decouple and expose the internal Input state. The workflow remains the same for all Godot devs, so this just makes the Input API more flexible.

It would be good to be able to override InputDefault implementation via modules instead, but I haven't found a way of doing so yet, so consider this proposal to be a demonstration over the limitations I'm dealing with input handling in Godot.

Test project

https://github.com/Xrayez/godot-input-state-demo

@groud
Copy link
Member

groud commented Jan 17, 2020

See my comment there: godotengine/godot-proposals#104 (comment)

@Xrayez
Copy link
Contributor Author

Xrayez commented Mar 26, 2020

#37317:

  • Input was renamed to InputFilter.
  • InputDefault is removed.

These introduce too many changes for this PR to be rebased and it's easier to just redo this, so closing. But also see godotengine/godot-proposals#104 (comment).

You can still test this PR if you wish so, I'm not going to delete the branch for now.

@Xrayez Xrayez closed this Mar 26, 2020
@akien-mga akien-mga added this to the 4.0 milestone Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants