Do not remove ragdoll collision layers after simulation disabled

[Acvarium]

Those two lines that I removed clear collision layers and masks for each bone, if simulation was disabled.
With that collision detection doesn't work any more.
Here is how it works right now:
https://youtu.be/H0wkiiwg4bI

And here is how it has to work, and is without those lines:
https://youtu.be/m2KjrekxD0Y

(in videos the act of shooting enable a simulation, and a keypress disable it and returns character to default position)

If game developer want to clear collision layers, he/she can do that in the script.

[AndreaCatania]

After the deactivation the physical skeleton are supposed to remain inplace.
you can see that this function _stop_physics_simulation not only change the layer and the mask but also change the body mode to static.

The correct approach is to add another state (Kinematic):

• Active (The bones are fully simulated by the physics)
• Kinematic (The physical bones are moved by the animation)
• Deactivated (The physical bones are fully deactivated)

[Acvarium]

About, "The physical bones are moved by the animation", as I can see, it doesn't work at all. For bones to move with animation with simulation disabled, I added a workaround in game script, in form of 3 lines, that go thru each physic bone and correct it's transform to transform of a corresponding animation bone

[AndreaCatania]

Exactly, what I mean is that the physical bone should support this functionality.

…

On Sat, Dec 14, 2019, 20:06 Acvarium ***@***.***> wrote: About, "The physical bones are moved by the animation", as I can see, it doesn't work at all. For bones to move with animation with simulation disabled, I added a workaround in game script, in form of 3 lines, that go thru each physic bone and correct it's transform to transform of a corresponding animation bone — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#34313?email_source=notifications&email_token=AB7UYR7V3AY5LFVRE42H3GDQYUVCHA5CNFSM4J2EGK72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4I7PQ#issuecomment-565743550>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7UYR7LTTCY5ONOLZAPEC3QYUVCHANCNFSM4J2EGK7Q> .

[AndreaCatania]

This feature got already integrated by this one #36008

[aaronfranke]

@AndreaCatania Does that mean that this PR should be closed?

@Acvarium If this still desired, it needs to be rebased on the latest master branch.

[AndreaCatania]

Yep, it's already implemented.

[akien-mga]

Closing then. Thanks for the contribution nevertheless!