Viewport environment is updated properly when set to own world #33987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better to leave out cosmetic style changes as they make the functional changes harder to review in the diff. We'll do all cosmetic changes using tools like You can of course use the consensual style on the added/modified code. |
|
Good to know! I'll revert these and restrain myself in the future. |
When own_world property is set, the viewport stores a unique resource for the world. With this change it keeps being updated from changes made to the world property instead of storing a default empty world with environment settings that can't be modified. Fixes godotengine#23412
pouleyKetchoupp
force-pushed
the
own-world-environment
branch
from
c8f6d4f to
dc13750
Compare
|
Great fix! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
own_worldproperty is set, theViewportstores a unique resource for the world. With this change it keeps being updated from changes made to theworldproperty instead of storing a default empty world with environment settings that can't be modified.Fixes #23412