-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IBL specular persisting when specular disabled #33694
Conversation
Not sure about this, it seems to me that the problem in the original issue is something else and it should be properly researched. |
From what I understand, the problem the user is having is that they are seeing specular highlights even when specular is disabled. They also think that setting "specular" to 0 should reduce the effect of specular highlights. But they are misunderstanding what the specular parameter does. fracteed does a nice job of explaining what the slider is for. From a design perspective. We are giving the users the ability to disable specular, but it only disables specular from lights, not from IBL. The user is trying to disable all specular but is seeing no change when in an IBL-only scene. They also mistake fully-rough specular for specular being turned off. |
af38d67
to
c3ae1cc
Compare
c3ae1cc
to
2dd2ca3
Compare
Reduz and I discussed this over IRC. We concluded the best option would be to clarify that the current It makes sense to treat the specular lobe differently from specular reflections. Once the Vulkan branch has been merged into master I will update this PR to reflect the above decision. |
@clayjohn Vulkan has been merged into master, so you can update this PR now. |
Superseded by #41415? |
@akien-mga not quite. I will edit this to expose a disable-specular property to StandardMaterial3D |
Superseded by #63587 |
Fixes: #33616
SPECULAR_DISABLED
wasn't affecting IBL specular. So in PBR scenes, there were still specular highlights even when specular was disabled.