Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the node deletion confirmation message #32094

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 11, 2019

Follow-up to #31942.

  • Add "the root node" in the beginning if the selected node is the current scene's root
  • Add "and its children" at the end of the message if the node has at least one child and is not an instanced scene

See discussion in godotengine/godot-proposals#59.

- Add "the root node" in the beginning if the selected node
  is the current scene's root
- Add "and its children" at the end of the message if the node
  has at least one child and is not an instanced scene
@akien-mga akien-mga added this to the 3.2 milestone Sep 20, 2019
@akien-mga akien-mga merged commit 769a9c5 into godotengine:master Sep 20, 2019
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the improve-delete-node-confirmation-2 branch January 27, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants