-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extents for GPU and CPU Particles2D emission points #30665
Added extents for GPU and CPU Particles2D emission points #30665
Conversation
Is this change relevant for CPUParticles2D as well? If so, that needs to be implemented as well. |
The emission mask now uses relative values which are multiplied by the emission extents. This also fixes the issue where emission points are dependent on original texture size. This commits also change emission points texture to be centered on the particle system instead of placing the top left corner at the center. I think this also fixes godotengine#16411 Added CPU particles
3edd49e
to
954e24e
Compare
@clayjohn Done. |
@eligt Is this still desired? If so, it needs to be rebased on the latest master branch. |
@aaronfranke @eligt I'd still really like to see this change. |
I'm not convinced that this is the right solution for the problem at hand.
|
Seems like there is no consensus on the solution, nor has there been any activity with this PR for a while. Since we're at the end of the beta stage, I have to close this. An agreed upon solution to the presented problems that doesn't break compatibility is likely still welcome in future. |
The emission mask now uses relative values which are multiplied by the emission extents. This also fixes the issue where emission points are dependent on original texture size.
This commits also change emission points texture to be centered on the particle system instead of placing the top left corner at the center.
I think this also fixes #16411