Document CollisionObject2D pickable requires collision_layer #28552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!
|
mhilbrunner
requested changes
May 1, 2019
|
Sorry, stupid typo + copy paste. Fixed. |
|
No worries, thanks for the fix! Can you squash your commits into one? |
The bake mode property of lights previously didn't affect GI probes. This change makes the GI probe ignore lights that have their bake mode set to disabled.
Documents CollisionObject2D mouse_entered, mouse_exited and input_event requiring at least one collision_layer to be set.
|
Sheesh, I seem to be not up to par today, sorry. I messed that squash up as well. oh boy... |
|
Again, no worries! I had to get used to the GitHub workflow too :) Maybe this can help: If it doesn't, if you want you can also close this PR and submit the (intended) changes as a new PR :) |
|
Yeah, I'm not used to squashing. I'll open a new PR, messing around with this PR for 3 lines is wasted time. |
|
new PR: #28608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document CollisionObject2D signals
mouse_entered,mouse_exitedandinput_eventrequire at least onecollision_layerto be set.Sadly,
collision_layeris implemented, and thus documented in the child classesArea2DandPhysicsBody2D(why not in the parent class?), so this might be a source of confusion.Clarifies #11159