Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve new Connections dialog #27965

Closed
wants to merge 1 commit into from
Closed

Improve new Connections dialog #27965

wants to merge 1 commit into from

Conversation

YeldhamDev
Copy link
Member

  • Fixed dialog not correctly reopening in advanced mode once enabled and closed,
  • Added tooltips to "Deferred" and "Oneshot".
  • Made "Advanced" into a CheckButton and the "Deferred" and "Oneshot" into CheckBoxes (see here why).
  • Made the dialog just readjust its size instead of reopening when advanced mode is enabled.

@YeldhamDev YeldhamDev changed the title Improve new Conections dialog Improve new Connections dialog Apr 12, 2019
@Chaosus Chaosus added this to the 3.2 milestone Apr 13, 2019
@YeldhamDev YeldhamDev mentioned this pull request Apr 17, 2019
Closed
@YeldhamDev
Copy link
Member Author

With the progress of #27988, and it being superior to this PR, I will be closing this.

@YeldhamDev YeldhamDev closed this Apr 20, 2019
@YeldhamDev YeldhamDev deleted the connections_dialog_improvements branch April 20, 2019 15:52
@reduz
Copy link
Member

reduz commented Apr 20, 2019

I actually prefer this PR.

@YeldhamDev
Copy link
Member Author

@reduz I can open a new one with this code if you desire.

@YeldhamDev YeldhamDev mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived enhancement topic:editor usability
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @reduz @Chaosus