Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectSettings: fix category for per pixel transparency settings #26087

Merged

Conversation

akien-mga
Copy link
Member

CC @bruvzg if you have better name suggestions. All settings in display/window have a subsection, so those looked weird at the top without a subsection.

Poke @lekoder, if you're still using those you'll have to update your project settings once this is merged.

@akien-mga akien-mga added this to the 3.1 milestone Feb 20, 2019
@akien-mga akien-mga requested a review from reduz as a code owner February 20, 2019 13:44
@akien-mga akien-mga force-pushed the settings-per-pixel-transparency branch from 9a7768c to e7018e4 Compare February 20, 2019 13:45
@akien-mga akien-mga requested a review from a team as a code owner February 20, 2019 13:45
@bruvzg
Copy link
Member

bruvzg commented Feb 20, 2019

video_mode.layered is not used and should be remove completely, and per_pixel_transparency_splash renamed to per_pixel_transparency/enabled

https://github.com/godotengine/godot/blob/master/core/os/os.h#L105
https://github.com/godotengine/godot/blob/master/core/os/os.h#L116

Like this:

OS::get_singleton()->_allow_layered = GLOBAL_DEF("display/window/per_pixel_transparency/allowed", false);
video_mode.layered_splash = GLOBAL_DEF("display/window/per_pixel_transparency/enabled", false);

@akien-mga
Copy link
Member Author

Thanks, will do.

@akien-mga akien-mga merged commit 5d815a5 into godotengine:master Feb 20, 2019
@akien-mga akien-mga deleted the settings-per-pixel-transparency branch February 20, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants