Fix inherited icons for script classes #25676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 9, 2019
willnationsdev
force-pushed
the
fix-inherited-icons
branch
from
31463f8 to
cc68dc8
Compare
|
Updated |
willnationsdev
force-pushed
the
fix-inherited-icons
branch
from
cc68dc8 to
2d106eb
Compare
|
Thanks! |
|
Cherry-picked for 3.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #24657. I added a loop that goes through the base classes in the script class and checks if any of them have icons, all the way up until there aren't any more scripts.