No longer save all scripts automatically when closing the editor.

[Piet-G]

This fixes #18010.

[KellyThomas]

Will this show a "would you like to save changes?" prompt?

[Piet-G]

@KellyThomas No, but it will only not save when you disable the save_each_scene_on_quit property in the editor settings. Previously that setting was just ignored for scripts.

[akien-mga]

CC @Noshyaar

[ghost]

save_each_scene_on_quit was introduced here: #9304 (comment)

There are two styles of save dialog depending on save_each_scene_on_quit. If true (default behavior), it will go through each unsaved scenes and ask whether you want it to be saved or not. If false, you can either save all scenes already on the disk, discard all or cancel. It was added because

1. it's how other applications do it (GIMP afaik.)
2. it's a faster flow if you save constantly. You can just discard all and quit the editor quickly.
3. I kinda want the feedback whether this mode should be default or not.

(tbh I kinda regret adding it a bit since I don't think anyone would config it anyway and it bloats the editor settings.)

The logic when 'save all' is the same as clicking 'save all scenes' from the menu. The save_each_scene_on_quit property is not directly related to the script editor.

[akien-mga]

IMO we should drop the save_each_scene_on_quit option, I agree that most users hardly know about it so it's probably not worth having.

Instead, maybe the two behaviours could be merged into one? i.e. have in the dialog:

• Save current scene --> then moves on to next scene
• Save all scenes
• Discard current scene --> then moves on to next scene
• Discard all scenes
• Cancel

And same for scripts.

Of course 5 buttons would be too much, but maybe it could be done with 3 buttons + a checkbox "Apply to all scenes". Or if anyone has a better proposal :D

[akien-mga]

As per the above discussion, this is not a proper fix for #18010 as it uses an editor option intended for another use case, as described in #21854 (comment) (and further discussed in #21959).