Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API hash fixes #18514

Merged
merged 2 commits into from
May 3, 2018
Merged

API hash fixes #18514

merged 2 commits into from
May 3, 2018

Conversation

neikeq
Copy link
Contributor

@neikeq neikeq commented Apr 29, 2018

Methods inside the core API must not be bound only with TOOLS_ENABLED. That breaks the API between the editor player and the exported player.

@hpvb
Copy link
Member

hpvb commented Apr 29, 2018

This has already independently been pulled into 3.0.3. We can replace that with a different solution if that turns out to be desirable. In my tests this works for existing exported projects though.

hpvb added a commit that referenced this pull request Apr 29, 2018
This hasn't made it into master yet but is important for mono support.
If this turns out to be the wrong call we'll revert and merge whatever
next version of this becomes available.
@PJB3005 PJB3005 mentioned this pull request May 2, 2018
4 tasks
@akien-mga akien-mga merged commit b774156 into godotengine:master May 3, 2018
@neikeq neikeq deleted the api-hash-fixes branch May 13, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants