Fix some Coverity warnings in String API #18281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- StringName::StringName(const StringName &p_name) Non-static class member _data is not initialized in this constructor nor in any functions that it calls. - StringName::_Data() Non-static class member idx is not initialized in this constructor nor in any functions that it calls. - String::num_uint64(...) This less-than-zero comparison of an unsigned value is never true. n % base < 0UL. - String::hex_to_int(...) and String::hex_to_int64(...) Execution cannot reach this statement (deadcode)
akien-mga
commented
Apr 18, 2018
| @@ -67,6 +67,7 @@ class StringName { | |||
| _Data() { | |||
| cname = NULL; | |||
| next = prev = NULL; | |||
| idx = 0; | |||
There was a problem hiding this comment.
Coverity also reports:
Non-static class member field
refcount.countis not initialized in this constructor nor in any functions that it calls.
But I'm not sure how/if it should be fixed. The code that actually uses _data always seems to do _data->refcount.init();, I guess it could be made here too?
There was a problem hiding this comment.
Or should we make SafeRefCount initialize its count to 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringName::StringName(const StringName &p_name)
Non-static class member _data is not initialized in this constructor nor in any functions that it calls.
StringName::_Data()
Non-static class member idx is not initialized in this constructor nor in any functions that it calls.
String::num_uint64(...)
This less-than-zero comparison of an unsigned value is never true. n % base < 0UL.
String::hex_to_int(...) and String::hex_to_int64(...)
Execution cannot reach this statement (deadcode)