Correct next-line calculation for RichTextEdit #17144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that after 77b1320 the line height of the first line in a RichTextEdit is no longer correctly calculated compared to the following lines. By subtracting the line_descent from the next y base coordinate of the next line we get the correct result.
|
CC @poke1024 for review. |
This was referenced Mar 1, 2018
|
it looks good to make correct baseline on the same line with different font size |
|
I think #17145 is the correct fix. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that after 77b1320 the line height of the first line in a
RichTextEdit is no longer correctly calculated compared to the following
lines. By subtracting the line_descent from the next y base coordinate
of the next line we get the correct result.
Comparisons:
3.0-stable
3.0.1-stable
This pr:
And with multiple font sizes:
3.0-stable
3.0.1-stable
This pr:
I believe this fixes #17139