-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono project export #16920
Mono project export #16920
Conversation
@@ -274,8 +274,6 @@ void EditorExportPlatform::gen_debug_flags(Vector<String> &r_flags, int p_flags) | |||
} | |||
|
|||
Error EditorExportPlatform::_save_pack_file(void *p_userdata, const String &p_path, const Vector<uint8_t> &p_data, int p_file, int p_total) { | |||
if (p_path.ends_with(".so") || p_path.ends_with(".dylib") || p_path.ends_with(".dll")) | |||
return OK; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @karroffel @endragor Follow up from #11580 (review). I don't know if this will break anything.
ca9018c
to
a38b59b
Compare
@neikeq so just to test I grabbed master and built all the export templates for windows 10 64 bit. In the https://bitbucket.org/G4MR/godot-breaker/src bin folder you should find the release/debug executables that I ran which gives me errors.
https://i.imgur.com/wta4Cb4.png You can see all the source in that repo if you want to attempt to reproduce. Hope this helps with the ongoing efforts for getting exporting stable. 👍 |
I think the core API changes between |
hmm, I'll test it again later |
Cherry picked into 3.0.3 |
Just a WIP, but worth being merged at this point.
TODO (not in this PR):
_export_begin
not being called with the "Export PCK" option. I used this patch for testing purposes but, as you can see, it doesn't take Debug/Release and the output path into account: