Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken variant call of Vector3.snapped #16362

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Fix broken variant call of Vector3.snapped #16362

merged 1 commit into from
Feb 3, 2018

Conversation

clktmr
Copy link
Contributor

@clktmr clktmr commented Feb 3, 2018

No description provided.

@vnen vnen added this to the 3.1 milestone Feb 3, 2018
@vnen
Copy link
Member

vnen commented Feb 3, 2018

This is broken since the beginning of time...

@vnen vnen merged commit ba6a0a3 into godotengine:master Feb 3, 2018
@hpvb
Copy link
Member

hpvb commented Feb 4, 2018

Is there any way that the previous behavior did something sensible (if undocumented?) this makes me a little nervous for cherry picking into 3.0

@vnen
Copy link
Member

vnen commented Feb 4, 2018

@hpvb in my tests it just returned the same vector.

@akien-mga
Copy link
Member

akien-mga commented Feb 13, 2018

This is broken since the beginning of time...

Actually no, only since June 2017: 44ecfb0.

Vector3.snapped used to use a float as parameter, but the bindings weren't updated properly. We need to be extra careful with Variant changes, most contributors have no idea about how they're bound and thus miss some stuff.

@hpvb
Copy link
Member

hpvb commented Feb 21, 2018

As this changes api/abi I don't think this should go into 3.0, it may break existing gdnative modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants