Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for compiling the new lightmapper #14657

Merged

Conversation

Valentactive
Copy link
Contributor

also changed a call in scene/3d/baked_lightmap.cpp that was ambiguous

Here the build error before:
issue_compiling_voxellightbaker

@akien-mga
Copy link
Member

Looks good, but @bruvzg had another error on macOS, could you fix it too?

scene/3d/voxel_light_baker.cpp:1032:15: error: call to 'pow' is ambiguous
                float att = Math::pow(1.0 - angle / p_spot_angle, p_spot_attenuation);
                            ^~~~~~~~~

(should also be 1.0f)

@ghost ghost mentioned this pull request Dec 14, 2017
@akien-mga
Copy link
Member

Please squash the two commits together.

also changed two calls that were ambiguous
@Valentactive Valentactive force-pushed the fix_compiling_new_lightmapper branch from f3844db to dea5ba3 Compare December 14, 2017 15:24
@akien-mga akien-mga merged commit b872439 into godotengine:master Dec 14, 2017
@Valentactive Valentactive deleted the fix_compiling_new_lightmapper branch February 18, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants