Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]Completed LineEdit.xml #12445

Merged
1 commit merged into from
Oct 29, 2017
Merged

[DOCS]Completed LineEdit.xml #12445

1 commit merged into from
Oct 29, 2017

Conversation

MattUV
Copy link
Contributor

@MattUV MattUV commented Oct 27, 2017

I filled the LineEdit.xml file. However:

  • I completed the ALIGN_FILL description but the code currently does nothing. It should be fixed, or the documentation should be modified
  • I did not complete the MENU_MAX description, because it seems deprecated (or not implemented yet). This constant appears only in LineEdit.cpp and TextEdit.cpp and in both cases it does nothing. Should we delete it?
  • I did not complete the Theme Items section. Should I?

This is my second commit in the docs, I hope I did things right.

@ghost ghost added this to the 3.0 milestone Oct 27, 2017
</constant>
<constant name="ALIGN_CENTER" value="1">
Align center.
Centers the thext in the middle of the [LineEdit].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thext -> text

</member>
<member name="placeholder_alpha" type="float" setter="set_placeholder_alpha" getter="get_placeholder_alpha">
Opacity of the [member placeholder text]. From [code]0[/code] to [code]1[/code].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be [member placeholder_text] with an underscore?

@MattUV MattUV force-pushed the docs-editing branch 2 times, most recently from 5a16fd7 to 97e01ab Compare October 28, 2017 14:10
@MattUV
Copy link
Contributor Author

MattUV commented Oct 28, 2017

Thanks. It should be good now.

</member>
<member name="secret" type="bool" setter="set_secret" getter="is_secret">
If [code]true[/code], every character is shown as "*".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comma

</member>
<member name="expand_to_len" type="bool" setter="set_expand_to_text_length" getter="get_expand_to_text_length">
If [code]true[/code], the [LineEdit] width will increase to stay longer than the [member text]. It will [b]not[/b] compress if the [member text] is shortened.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comma

</member>
<member name="editable" type="bool" setter="set_editable" getter="is_editable">
If [code]false[/code], existing text cannot be modified and new text cannot be added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comma

</member>
<member name="caret_blink" type="bool" setter="cursor_set_blink_enabled" getter="cursor_get_blink_enabled">
If [code]true[/code], the caret (visual cursor) blinks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comma

$LineEdit.text = "Welcome"
select() # Welcome
select(4) # ome
select(2, 5) # lco
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the LineEdit node is named "LineEdit", you need to use $LineEdit.select(), or change to text = "Welcome"

@MattUV
Copy link
Contributor Author

MattUV commented Oct 28, 2017

Why so much hate against commas? You just made them cry :,-(
Thanks for correcting me, I updated the commit

@ghost ghost merged commit 84edb58 into godotengine:master Oct 29, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants