Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Vector2.angle_to returns a signed angle #102824

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

3DartBlade
Copy link
Contributor

Added a minor detail to the description of "angle_to" so that it specifies that the returned angle is signed. Hopefully helps others not to waste several hours not realizing this.

Added a minor detail to the description of "angle_to" so that it specifies that the returned angle is signed. Hopefully helps others not to waste several hours not realizing this.
@3DartBlade 3DartBlade requested a review from a team as a code owner February 13, 2025 21:01
@tetrapod00 tetrapod00 added this to the 4.x milestone Feb 13, 2025
@akien-mga akien-mga changed the title Updated "Vector2.angle_to" description in Vector2.xml Clarify that Vector2.angle_to returns a signed angle Feb 13, 2025
@tetrapod00
Copy link
Contributor

For reference, the Vector3 equivalent functions differently and already clarifies the signedness:

<method name="angle_to" qualifiers="const">
<return type="float" />
<param index="0" name="to" type="Vector3" />
<description>
Returns the unsigned minimum angle to the given vector, in radians.
</description>
</method>

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Feb 14, 2025
@Repiteo Repiteo merged commit f419873 into godotengine:master Feb 14, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 14, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants