Clarify the behavior of Control.layout_direction in the documentation
#102716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
doc-control-layout-direction
branch
from
1907aa4 to
c7e0e2c
Compare
Calinou
force-pushed
the
doc-control-layout-direction
branch
from
c7e0e2c to
8217cda
Compare
AThousandShips
added
enhancement
documentation
cherrypick:4.2
Calinou
removed
the
cherrypick:4.2
Calinou
force-pushed
the
doc-control-layout-direction
branch
from
8217cda to
65c795e
Compare
akien-mga
approved these changes
Feb 11, 2025
bruvzg
reviewed
Feb 11, 2025
| @@ -1372,7 +1372,7 @@ | |||
| Automatic layout direction, determined from the parent control layout direction. | |||
| </constant> | |||
| <constant name="LAYOUT_DIRECTION_APPLICATION_LOCALE" value="1" enum="LayoutDirection"> | |||
| Automatic layout direction, determined from the current locale. | |||
| Automatic layout direction, determined from the current locale. Right-to-left layout direction is automatically used for languages that require it such as Arabic and Hebrew., but only if a valid translation file is loaded for the given language. For all other languages (or if no valid translation file is found by Godot), left-to-right layout direction is used. If using [TextServerFallback] ([member ProjectSettings.internationalization/rendering/text_driver]), left-to-right layout direction is always used regardless of the language. | |||
There was a problem hiding this comment.
but only if a valid translation file is loaded for the given language
After #102649, it's also possible to set internationalization/locale/fallback to RTL language without translation files (if it's the only supported language).
There's also internationalization/rendering/force_right_to_left_layout_direction property for testing.
There was a problem hiding this comment.
Oops I overlooked this when merging. That can be improved in a follow-up.
There was a problem hiding this comment.
Pull request opened:
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also incorporates the documentation change from #91824.