Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the rendering/renderer/rendering_method.mobile project setting to the AndroidManifest #102446

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Feb 5, 2025

The AndroidManifest already stores the Godot editor and library versions. The addition of this meta-data allows to identify Godot Android apps that may be subject to renderer specific issues addressed in future versions of the engine.

…ng to the AndroidManifest

The AndroidManifest already stores the Godot editor and library versions. The addition of this meta-data allows to identify Godot Android apps that may be subject to renderer specific issues addressed in future versions of the engine.
@m4gr3d m4gr3d added this to the 4.4 milestone Feb 5, 2025
@m4gr3d m4gr3d requested a review from dsnopek February 5, 2025 05:18
@m4gr3d m4gr3d requested a review from a team as a code owner February 5, 2025 05:18
@clayjohn
Copy link
Member

clayjohn commented Feb 5, 2025

Will this cause any issues if users change the renderer after exporting? It is possible that users expose a setting in their game that changes the renderer

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Feb 5, 2025

Will this cause any issues if users change the renderer after exporting? It is possible that users expose a setting in their game that changes the renderer

It won't cause any issues as the meta-data entry in the manifest is ignored at runtime. Here it acts primarily as a logging mechanism so static analysis can be done on the generated binary to see which rendering_method is set as the default at start time.

@clayjohn
Copy link
Member

clayjohn commented Feb 5, 2025

It won't cause any issues as the meta-data entry in the manifest is ignored at runtime. Here it acts primarily as a logging mechanism so static analysis can be done on the generated binary to see which rendering_method is set as the default at start time.

Makes sense!

Copy link
Member

@syntaxerror247 syntaxerror247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Repiteo Repiteo merged commit 202fa8e into godotengine:master Feb 5, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 5, 2025

Thanks!

@m4gr3d m4gr3d deleted the export_renderer_project_setting_to_manifest branch February 5, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants