Linux/BSD: Modify only keypad keys #102169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
|
I can confirm this fixes the number pad issue mention on #101848. |
Calinou
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Tested locally, it works as expected. The issue with script editor hover tooltips no longer appearing until you alt-tab out and back in is also fixed with this PR.
Disabling numlock in the script editor works as intended for navigational purposes, but this was also the case in master before this PR.
Code looks good to me.
Operating System: Fedora Linux 41
KDE Plasma Version: 6.2.5
KDE Frameworks Version: 6.10.0
Qt Version: 6.8.1
Kernel Version: 6.12.9-200.fc41.x86_64 (64-bit)
Graphics Platform: X11
Before
| Numlock OFF | Numlock ON |
|---|---|
 |
 |
After
Notice that Unicode is now "Kp 0" instead of "0" for Numlock ON.
| Numlock OFF | Numlock ON |
|---|---|
 |
 |
bruvzg
requested changes
Feb 2, 2025
Riteo
force-pushed
the
what-is-even-a-keypad
branch
from
510f03f to
140a63b
Compare
The `keycode` field of `InputEventKey` is supposed to be "unshifted"; That is, what the key would output if no modifier keys were pressed. This should match what's written on the key label, but `Key` enumerates also all keypad keys, which require a modifier. We thus require some extra checks for them. Note that this can still allow "stuck keys", but that's an even deeper problem.
bruvzg
approved these changes
Feb 2, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should greatly alleviate #102137.
Fixes #102259.
The
keycodefield ofInputEventKeyis supposed to be "unshifted"; That is, what the key would output if no modifier keys were pressed. This should match what's written on the key label, butKeyenumerates also all keypad keys, which require a modifier. We thus require some extra checks for them.Note that this can still allow "stuck keys", but that's an even deeper problem.
This should bring both the X11 and Wayland backend to "parity" with Windows. Now only keypad keys should be able to get stuck; Better than having every other "non-US" modifier at least.
Feedback appreciated on the X11 impl.
Also note that I purposely made the "is keypad" method specific to only the related (modified)
Keyenumerations. If that's excessive, we could replace it with a simple check betweenXKB_KEY_KP_SpaceandXKB_KEY_KP_9(same for the XK equivalent on X11), as all keypad scancodes are consecutive. That would require no other changes as I built the code to allow for "no matches" to the mapping table, just in case.CC @bruvzg